Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logger property render bug #255

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Fix logger property render bug #255

merged 3 commits into from
Aug 30, 2023

Conversation

Arkatufus
Copy link
Contributor

Changes

  • Use Serilog internal formatter to properly format log messages

Aaronontheweb
Aaronontheweb requested changes Aug 30, 2023
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, as far as I know - but can we get some snapshot tests with Verify on Akka.NET v1.4 (separate PR) and then bring it into dev ? That way we know if we're moving someone else's cheese around with this change.

@Arkatufus Arkatufus mentioned this pull request Aug 30, 2023
Open
@Arkatufus
Copy link
Contributor Author

@Aaronontheweb #257

Aaronontheweb
Aaronontheweb reviewed Aug 30, 2023
View reviewed changes
src/Akka.Logger.Serilog/SerilogLogMessageFormatter.cs
@@ -37,6 +38,9 @@ public SerilogLogMessageFormatter()
/// </returns>
public string Format(string format, params object[] args)
{
if (Log.Logger.BindMessageTemplate(format, args, out var boundTemplate, out var boundProps))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment explaining what this does and how the fallback mechanism works

@Arkatufus Arkatufus enabled auto-merge (squash) August 30, 2023 23:49
@Arkatufus Arkatufus merged commit 9cdd935 into akkadotnet:dev Aug 30, 2023
1 check passed
@Arkatufus Arkatufus mentioned this pull request Aug 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkatufus @Aaronontheweb